search

elisa-tech / meta-elisa

MIT License
9 stars 16 forks source link

Request pull to add i6300 watchdog support to the ELISA demo #14

Closed cminyard closed 3 years ago

cminyard commented 3 years ago

We had a system fail for the work I was doing, so I had some time to work on this. I have two patches:

Add the bsp directory to the BBLAYERS.

Switch over to the i6300 watchdog.

A few notes:

If you just pull and rebuild, it won't work. The BBLAYERS will be wrong unless you re-run:

source meta-agl/scripts/aglsetup.sh -f  elisa-cluster-demo

or you edit build/conf/bblayers.conf and hand-add the changes.

I enabled nowayout on the watchdog. This seems like the most prudent thing on a safety critical system.

You might want to add some information to the README.md about how to run the demo. It took me a bit of time to figure it out, and I just kind of hacked something together that worked. If we have a preferred way to run the demo, that would be very handy for users.

-corey

sudipm-mukherjee commented 3 years ago

@cminyard I did a fresh rebuild, and I can see in lsmod that i6300esb module is loaded. But on triggering the safe state the system does not reset. Do I need to add anything in the qemu argument to enable the watchdog?

sudipm-mukherjee commented 3 years ago

Ok, I checked and we will need to add -watchdog i6300esb to qemu commandline. And I can confirm it works properly.

Jochen-Kall commented 3 years ago

Hi Corey,

thanks for taking care of this, I'll give it a try tonight.

Good point you are making, the readme is a bit light on building instructions and running instructions with QEMU are missing entirely. There were some in the document Jan-Simon provided, but they didn't make their way into the readme it seems.

We should also add the info that meta-elisa is an agl feature template now.

Jochen-Kall commented 3 years ago

Builds, runs and behaves as expected for me.

cminyard commented 3 years ago

On Thu, Mar 04, 2021 at 05:03:59AM -0800, Jochen Kall wrote:

Builds, runs and behaves as expected for me.

Thanks for checking it out. I should have mentioned enabling the watchdog hardware emulator.