DelphianCalamity commented 5 years ago

This pull request allows using S3 as well as ftp. Please note that in files: src/main/resources/application.properties, src/main/resources/taskmaster.json is used an image served from our gitlab organization instead of eu.gcr.io/tes-wes/... This is needed so that the image contains the S3 compatible taskmaster. Should you accept this PR you should also serve this image from eu.gcr.io.

This PR depends on https://github.com/EMBL-EBI-TSI/tesk-core/pull/12 being accepted.

codecov[bot] commented 5 years ago

Codecov Report

Merging #2 into master will increase coverage by 0.28%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   83.35%   83.63%   +0.28%     
==========================================
  Files          35       35              
  Lines         913      929      +16     
  Branches       96       97       +1     
==========================================
+ Hits          761      777      +16     
  Misses        108      108              
  Partials       44       44

Impacted Files	Coverage Δ
...va/uk/ac/ebi/tsc/tesk/util/constant/Constants.java	`75% <ø> (ø)`	:arrow_up:
...ebi/tsc/tesk/config/KubernetesObjectsSupplier.java	`96.15% <100%> (+0.5%)`	:arrow_up:
...c/ebi/tsc/tesk/config/TaskmasterEnvProperties.java	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cc9842...6426277. Read the comment docs.

zagganas commented 2 years ago

This functionality is already supported since TESK v1.0. Thank you for contributing :).

elixir-cloud-aai / tesk-api

S3 support #2

Codecov Report