elixir-cloud-aai / tesk-api

GA4GH TES API Service that translates tasks into Kubernetes Batch API calls
Apache License 2.0
7 stars 18 forks source link

fix: api-docs JSON example #30

Closed lvarin closed 1 year ago

lvarin commented 2 years ago

The api-docs json definition of the API was not passing the JSON parsing. One of the examples (in colunm ~1580, with text us-west-1), needed quotes,

codecov[bot] commented 1 year ago

Codecov Report

Base: 55.52% // Head: 55.47% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (fc72d38) compared to base (27a1323). Patch coverage: 60.56% of modified lines in pull request are covered.

:exclamation: Current head fc72d38 differs from pull request most recent head db5a7b9. Consider uploading reports for the commit db5a7b9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30 +/- ## ========================================== - Coverage 55.52% 55.47% -0.05% ========================================== Files 64 64 Lines 2064 2118 +54 Branches 217 231 +14 ========================================== + Hits 1146 1175 +29 - Misses 787 803 +16 - Partials 131 140 +9 ``` | [Impacted Files](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai) | Coverage Δ | | |---|---|---| | [...ain/java/uk/ac/ebi/tsc/tesk/config/GsonConfig.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svY29uZmlnL0dzb25Db25maWcuamF2YQ==) | `100.00% <ø> (ø)` | | | [...sc/tesk/config/swagger/OAuth2ClientProperties.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svY29uZmlnL3N3YWdnZXIvT0F1dGgyQ2xpZW50UHJvcGVydGllcy5qYXZh) | `88.88% <ø> (ø)` | | | [...bi/tsc/tesk/k8s/config/KubernetesClientConfig.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbmZpZy9LdWJlcm5ldGVzQ2xpZW50Q29uZmlnLmphdmE=) | `92.85% <ø> (ø)` | | | [.../uk/ac/ebi/tsc/tesk/k8s/constant/K8sConstants.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnN0YW50L0s4c0NvbnN0YW50cy5qYXZh) | `85.71% <ø> (ø)` | | | [...i/tsc/tesk/k8s/convert/ExecutorCommandWrapper.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvRXhlY3V0b3JDb21tYW5kV3JhcHBlci5qYXZh) | `100.00% <ø> (ø)` | | | [.../tsc/tesk/k8s/convert/TaskmasterEnvProperties.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvVGFza21hc3RlckVudlByb3BlcnRpZXMuamF2YQ==) | `91.66% <ø> (ø)` | | | [.../java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Job.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvZGF0YS9Kb2IuamF2YQ==) | `88.88% <ø> (ø)` | | | [.../tsc/tesk/k8s/convert/data/SingleTaskStrategy.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvZGF0YS9TaW5nbGVUYXNrU3RyYXRlZ3kuamF2YQ==) | `90.90% <ø> (ø)` | | | [...java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Task.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvZGF0YS9UYXNrLmphdmE=) | `93.54% <ø> (ø)` | | | [.../ac/ebi/tsc/tesk/k8s/convert/data/TaskBuilder.java](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#diff-c3JjL21haW4vamF2YS91ay9hYy9lYmkvdHNjL3Rlc2svazhzL2NvbnZlcnQvZGF0YS9UYXNrQnVpbGRlci5qYXZh) | `100.00% <ø> (ø)` | | | ... and [16 more](https://codecov.io/gh/elixir-cloud-aai/tesk-api/pull/30?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.