elixir-europe / rdmkit

ELIXIR Data Management Toolkit - Find the answers to your research data management questions here.
https://rdmkit.elixir-europe.org
Other
82 stars 133 forks source link

Make national resource page more visible #1123

Closed Nazeeefa closed 6 months ago

Nazeeefa commented 1 year ago

National resource page for a country itself is not so visibly mentioned under relevant pages. The only way to find a link to a national resource page is when you click on 'View national resources' and hover over a flag icon. This is subtle and can be hard to find or easily missed. See gif attached (showing part of 'NeLS' tool assembly page). national_resources

Suggested solution Mention link to country page in the bar (space highlighted in screenshot below) when national resources are from one country, otherwise mention link to 'National resources' section (when national resources from multiple countries are mentioned):

Screenshot 2022-12-08 at 12 36 32

It could also be useful to make 'View national resources' button more visible by perhaps adding flag icon to the button itself?

bianchini88 commented 1 year ago

This is particularly relevant for "national" tool assemblies.

korbinib commented 1 year ago

Could there be a way to trigger the expansion through a flag/setting for a whole page?

bedroesb commented 1 year ago

This should be possible! I started a while ago with experimenting in how we could improve this: https://github.com/ELIXIR-Belgium/elixir-toolkit-theme/pull/119

bedroesb commented 1 year ago

@Nazeeefa

Mention link to country page in the bar (space highlighted in screenshot below):

Do you mean the overview page with all countries?

Nazeeefa commented 1 year ago

This is indeed mostly relevant for 'Tool Assemblies' pages. @bedroesb I meant mentioning link to a specific country page when national resources from one country are mentioned (e.g. mentioning link to Norway's national resources page on NeLS Tool Assembly) otherwise mention link to 'National resources' section in the case when national resources from multiple countries are mentioned (e.g. on Covid-19 Portal 'Tool Assembly' page https://rdmkit.elixir-europe.org/covid19_data_portal). Hope this helps, thanks

bedroesb commented 6 months ago

National resources have now their own subheading so it is more visible than ever! I will close this issue since #1366 is merged, thanks for bringing this up!

Nazeeefa commented 6 months ago

Thanks @bedroesb what do you mean by subheading? From what I see, national resources section already had a heading 'National resources', no? :D I do see the new section called Affiliations, which leads to national resources page and ELIXIR Europe. I think it should be ELIXIR Norway webpage.

bedroesb commented 6 months ago

Well based on your suggestion in this issue and the screenshot in your description, you can see it was just a button before and it used to be a part of the existing table, and now it has its own H3 heading + its own table :sweat_smile: