search

elixir-geolix / geolix

IP information lookup provider
Apache License 2.0
190 stars 18 forks source link

Add :poolboy as an application #7

Closed whitfin closed 8 years ago

whitfin commented 8 years ago

Per https://hexdocs.pm/exrm/extra-common-issues.html, this is causing issue when using Exrm to package a release. The current workaround is to add :poolboy to your own application list, but it would be better to have it covered in the main geolix repo :)

mneudert commented 8 years ago

Definitely!

However the verification environment is now broken with an error: {:error, {:not_started, :poolboy}}. I think the Application.start/1 in the mix task (./verify/geolix/lib/mix/tasks/geolix/verify.ex) should be changed to Application.ensure_all_started/1.

Would you mind to include that into your patch? Like, squash it into the commit you have done?

Then I will just hit that nice merge button and give you the thanks you deserve ;)

whitfin commented 8 years ago

@mneudert sure I can make that change, let me see if it solves the problem :)

whitfin commented 8 years ago

@mneudert you were right :) I made the change and squashed it!

mneudert commented 8 years ago

Thank you very much :)