elixir-lang / tree-sitter-elixir

Elixir grammar for tree-sitter
https://elixir-lang.org/tree-sitter-elixir
Apache License 2.0
245 stars 24 forks source link

update rust bindings to include scanner and queries #30

Closed the-mikedavis closed 2 years ago

the-mikedavis commented 2 years ago

connects #29

This fixes cargo test runs and includes the highlight queries in the rust package.

the-mikedavis commented 2 years ago

I think it's worth discussing whether tree-sitter-elixir should be published to crates.io and/or npm. Some grammars are published (for example ruby) but many are not, and those that are do not usually get updated frequently. Most of the larger tree-sitter consumers I know take dependencies on grammars by git (either by submodules or shallow-clones), and you can do that with cargo and npm, so IMO there isn't really any benefit in publishing them.

jonatanklosko commented 2 years ago

@the-mikedavis I agree with everything you said, using Git dependencies sounds fine, so let's wait until there's a clear need for it being published :)