search

elixir-lang / tree-sitter-elixir

Elixir grammar for tree-sitter
https://elixir-lang.org/tree-sitter-elixir
Apache License 2.0
245 stars 24 forks source link

Loosen tree-sitter library bounds. #36

Closed patrickt closed 2 years ago

patrickt commented 2 years ago

The grammars should work fine with 0.19.

the-mikedavis commented 2 years ago

The only thing I know is a little rough on older tree-sitter versions for this grammar is this: https://github.com/tree-sitter/tree-sitter/issues/1444. Since tree-sitter-elixir uses newlines as extras and as non-extra rules (_terminator), an incremental change can end up putting the tree into an odd state on tree-sitter < 0.20.1. Incremental changes are not necessarily part of everyone's workflows though so I think it's ok đź‘Ť

patrickt commented 2 years ago

@the-mikedavis Makes sense; I think people who hit the incrementality bug can upgrade themselves (we’re stuck on 0.19, at least for now). I don’t have merge permissions on here, would you mind doing so (or adding me)?