@spec annotation suggestion missing parentheses

[my4ng]

Environment

• Elixir & Erlang versions (elixir --version): Erlang/OTP 25 [erts-13.2.2.1] [source] [64-bit] [smp:24:24] [ds:24:24:10] [async-threads:1] [jit:ns] Elixir 1.14.5 (compiled with Erlang/OTP 25)
• VSCode ElixirLS version: 0.14.7
• Operating System Version: linux 6.2.6-76060206-generic

Troubleshooting

• [x] Restart your editor (which will restart ElixirLS) sometimes fixes issues
• [x] Stop your editor, remove the entire .elixir_ls directory, then restart your editor

Details

As described in the title, the @spec annotation suggestion is missing parentheses after each built-in type, and hence they are not properly syntax highlighted, unlike custom defined types which do include the parentheses. I am new to elixir, so I am not sure if there's any rule regarding the consistency.

Example:

Custom type

@type t :: %T{
  ...
}

@spec f :: [t(), ...]
def f do
  [ %T{...}]
end

Builtin type

@spec add(number, number) :: number
def add(m, n), do: m + n

[lukaszsamson]

Elixir formatter does not care if no parens or parens version is used. While https://hexdocs.pm/elixir/typespecs.html seems to prefer parens form, the source code of elixir itself prefers no parens. We treat it as a stylistic choice to prefer no parens for builtin types.

Regarding the syntax highlighting, there are no specific rules for typespecs (https://github.com/elixir-lsp/vscode-elixir-ls/issues/311). Parens form gets highlighted as function call (entity.name.function-call.elixir source.elixir), no parens as variable (source.elixir).