lukaszsamson
commented
1 year ago Yes, there has been some changes aiming to correct issues in the grammar
Differentiation between module definition + module alias usage has disappeared
Should there be difference? In elixir AST both are the same.
note {:__aliases__, [line: _], [:Other, :Asdf]} in
iex(4)> Code.string_to_quoted("""
...(4)> defmodule Other.Asdf do
...(4)> def a do
...(4)> Other.Asdf.asd()
...(4)> end
...(4)> end
...(4)> """)
{:ok,
{:defmodule, [line: 1],
[
{:__aliases__, [line: 1], [:Other, :Asdf]},
[
do: {:def, [line: 2],
[
{:a, [line: 2], nil},
[
do: {{:., [line: 3],
[{:__aliases__, [line: 3], [:Other, :Asdf]}, :asd]}, [line: 3], []}
]
]}
]
]}}anyway, the difference is still there
usage in module is marked with scope meta.module.elixir
other usages does not have that scope
Identification of module attributes as distinct entities has disappeared
Do you mean that the scope has changed from variable.other.readwrite.module.elixir to more standard variable.other.constant.elixir? There were no entity.name. scope on module attributes.
Expected behavior Consistent token scopes and syntax highlighting across versions.
I cannot evolve the grammar without making some changes
bceskavich
jbosse
seanhuggins1
Environment
Current behavior
The latest release of ElixirLS for VSCode seems to remove a number of token scopes for Elixir, which in turn significantly changes the appearance of multiple syntax highlighting themes. The example below shows the following cases:
I am the author of the Dracula At Night VSCode theme, and the examples below use this theme. However, I've verified that this issue affects other popular themes as well (e.g. Cobalt2).
Expected behavior
Consistent token scopes and syntax highlighting across versions.