Closed PragTob closed 1 week ago
Totals | |
---|---|
Change from base Build 8516bcda190a644a5fe960b13869107ff76ee9b3: | 0.0% |
Covered Lines: | 1279 |
Relevant Lines: | 1463 |
Huh looks like some integration tests started failing over night:
1) test nghttp2.org SSL - select HTTP2 (Mint.IntegrationTest)
Error: test/mint/integration_test.exs:26
receive_stream timeout
code: assert {:ok, _conn, responses} = receive_stream(conn)
stacktrace:
test/mint/integration_test.exs:31: (test)
2) test TCP - nghttp2.org (HTTP2.IntegrationTest)
Error: test/mint/http2/integration_test.exs:35
Assertion failed, no matching message after 10000ms
The process mailbox is empty.
code: assert_receive message
stacktrace:
(mint 1.6.2) test/support/mint/http2/test_helpers.ex:10: Mint.HTTP2.TestHelpers.receive_stream/2
test/mint/http2/integration_test.exs:46: (test)
....
3) test nghttp2.org SSL - select HTTP1 (Mint.IntegrationTest)
Error: test/mint/integration_test.exs:11
receive_stream timeout
code: assert {:ok, _conn, responses} = receive_stream(conn)
stacktrace:
test/mint/integration_test.exs:16: (test)
..........
4) test nghttp2.org/httpbin GET / (HTTP2.IntegrationTest)
Error: test/mint/http2/integration_test.exs:245
Assertion failed, no matching message after 10000ms
The process mailbox is empty.
code: assert_receive message
stacktrace:
(mint 1.6.2) test/support/mint/http2/test_helpers.ex:10: Mint.HTTP2.TestHelpers.receive_stream/2
test/mint/http2/integration_test.exs:248: (test)
...
(obvs. unrelated to the PR or rhat'd be some real magic)
No worries about the tests. This is great. Thanks @PragTob 💟
Most outside documenation (Finch, Req) links just to
Mint.HTTP.connect/4
for documentation. That makes it somewhat hard to find both the case insesntitive header options as well as the not validating target options.Not sure it's worth duplicating them there, so I figured I'd just point to them - even if HTTP2 has no custom options as of now.
That's, of course, debatable. So, happy about feedback/improvements :)
Thank you!