elixir-plug / plug

Compose web applications with functions
https://hex.pm/packages/plug
Other
2.84k stars 582 forks source link

Plug Debugger add spacing between arguments #1242

Closed axelson closed 2 weeks ago

axelson commented 3 weeks ago

Some exceptions can have arguments that are very long when printed out (I'm looking at you %Plug.Conn{}!): Screenshot 2024-08-24 08-28-08@2x

This makes it very difficult to at-a-glance find the second, third, etc arguments (for what it's worth, I find this true in IEx as well). This PR improves this issue by adding some spacing between the arguments so that they stand out more as well as switching the numbers to use the primary color (but with 50% filter applied so it doesn't stick out too much). I like the coloring change because it makes it more clear that the numbers are not part of the exception itself.

Here's the changes: Screenshot 2024-08-24 08-47-21@2x

And here's the first screenshot with the changes:

Screenshot 2024-08-24 08-51-06@2x

josevalim commented 2 weeks ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

axelson commented 2 weeks ago

🎉