Closed jeregrine closed 1 year ago
FYI @josevalim has convinced me to try and port the current postgres/mysql connection tests to current sqlite since they appear to be an original fork from the first time this was tried. I won't include that here but something to keep in mind.
has convinced me to try and port the current postgres/mysql connection tests to current sqlite since they appear to be an original fork from the first time this was tried.
@jeregrine that would be awesome! I will not say no to fixes and more tests 😄
I have a small WIP where I copied the postgres connection tests over to this repo from ecto_sql and ported them. I put a bunch of TODO in places we should probably raise.
And for sure missed some others from the connection test you added in addition to the postgres specific tests.
I missed that the JSON
type with strict mode that we are wanting to enforce is not a valid type.
haha you're all good, sqlite is super permissive haha.
sqlite is super permissive
Which is why I didn't initially jump on the strict typing. I liked the flexibility, but it's probably smarter to be more strict.
https://github.com/elixir-sqlite/ecto_sqlite3/pull/101 discussion here
I was playing around some queries and noticed literals and selected_as was not implemented.
I also saw the comment about being unsure about floats so I just read the guide and it has CAST as if we know the type. I chose REAL but it looks like FLOAT would also work LMK if you think I should change it.