search

elixir-sqlite / exqlite

An SQLite3 driver for Elixir
https://hexdocs.pm/exqlite
MIT License
217 stars 48 forks source link

Unable to compile w/ OTP26 #252

Closed dtcaciuc closed 1 year ago

dtcaciuc commented 1 year ago

I believe the root cause is https://github.com/erlang/otp/issues/6916

However, even when I change Makefile.win to have -s erlang halt at the end of that line, make process hangs there without proceeding any further. Not sure where to go from here.

OTP 26.0.1 Elixir 15.0 Windows 11 Version 10.0.22621 Build 22621

warmwaffles commented 1 year ago

Oh that's not good. I'll need to add it to the test matrix for CI and figure that out.

warmwaffles commented 1 year ago

@dtcaciuc I recreated the hanging for the process in that PR above. I'll need some time to work through it. For now I recommend staying with OTP25 until I can get it resolved.

I don't have access to a windows dev environment to muck around on easily. I suspect the ultimate fix is to combine both of the makefiles into one.

dtcaciuc commented 1 year ago

Thank you for looking into this!

dtcaciuc commented 1 year ago

I think I found the issue, see https://github.com/erlang/rebar3/pull/2794

I removed [{encoding, unicode}] from setopts and the build succeeded. I don't know what the implications would be for OTP25 and lower tho.

warmwaffles commented 1 year ago

I'll take a look

warmwaffles commented 1 year ago

@dtcaciuc published under v0.13.14

warmwaffles commented 1 year ago

I still need to pull together the pre-compilation to support otp26