getTabId is not defined

[GuyKh]

After V3 migration (https://github.com/eljeffeg/SmartCopy/pull/124) - cc @mamsterla getting:

Error handling response: ReferenceError: getTabId is not defined
    at getPageCode (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:799:33)
    at Object.parseData (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/collections/findagrave.js:17:13)
    at loginProcess (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:204:28)
    at chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:873:9

pointing to this

[mamsterla]

I will take a look at that. Thanks. Adding Jeff G for visibility.

On Aug 14, 2024, at 4:35 AM, Guy Khmelnitsky @.***> wrote:

After V3 migration (#124 https://github.com/eljeffeg/SmartCopy/pull/124) - cc @mamsterla https://github.com/mamsterla getting:

Error handling response: ReferenceError: getTabId is not defined at getPageCode (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:799:33) at Object.parseData (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/collections/findagrave.js:17:13) at loginProcess (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:204:28) at chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:873:9 pointing to this https://github.com/eljeffeg/SmartCopy/blob/master/popup.js#L799 — Reply to this email directly, view it on GitHub https://github.com/eljeffeg/SmartCopy/issues/125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVHDUHEGFHOWCVT3M3IOLZRM6IRAVCNFSM6AAAAABMQEZ2MCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DKNJZGQYDGMA. You are receiving this because you were mentioned.

[mamsterla]

I just pushed changes on that branch to address the missing function

On Aug 14, 2024, at 10:19 AM, Michael Amster @.***> wrote:

I will take a look at that. Thanks. Adding Jeff G for visibility.

On Aug 14, 2024, at 4:35 AM, Guy Khmelnitsky @.***> wrote:

After V3 migration (#124 https://github.com/eljeffeg/SmartCopy/pull/124) - cc @mamsterla https://github.com/mamsterla getting:

Error handling response: ReferenceError: getTabId is not defined at getPageCode (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:799:33) at Object.parseData (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/collections/findagrave.js:17:13) at loginProcess (chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:204:28) at chrome-extension://ofikakkdpjlipbnhbfloclbkcabdhjah/popup.js:873:9 pointing to this https://github.com/eljeffeg/SmartCopy/blob/master/popup.js#L799 — Reply to this email directly, view it on GitHub https://github.com/eljeffeg/SmartCopy/issues/125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVHDUHEGFHOWCVT3M3IOLZRM6IRAVCNFSM6AAAAABMQEZ2MCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DKNJZGQYDGMA. You are receiving this because you were mentioned.

[GuyKh]

@mamsterla which branch? It's already merged (and rolled out)

[mamsterla]

It’s on the branch called V3-and-Ancestry-fixes, but let me work with Jeff to get this merged into the release

On Aug 14, 2024, at 11:11 AM, Guy Khmelnitsky @.***> wrote:

@mamsterla https://github.com/mamsterla which branch? It's already merged (and rolled out)

— Reply to this email directly, view it on GitHub https://github.com/eljeffeg/SmartCopy/issues/125#issuecomment-2289508501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVHDVROW67UTQWHVCO3CTZROMWLAVCNFSM6AAAAABMQEZ2MCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGUYDQNJQGE. You are receiving this because you were mentioned.

[mamsterla]

👍

Jeff G reacted via Gmail https://www.google.com/gmail/about/?utm_source=gmail-in-product&utm_medium=et&utm_campaign=emojireactionemail#app

[GuyKh]

@mamsterla - I guess you're mentioning the branch in your repo - https://github.com/mamsterla/SmartCopy/tree/v3-and-Ancestry-fixes Please note that the PR (on that branch) is already merged so I suggest rebasing into a new branch and starting a new PR