search

eljost / pysisyphus

Python suite for optimization of stationary points on ground- and excited states PES and determination of reaction paths.
GNU General Public License v3.0
95 stars 33 forks source link

use popen.communicate to replace popen.wait #274

Closed xjf729 closed 11 months ago

xjf729 commented 11 months ago

popen.wait may cause deadlock, popen.communicate will avoid that. ref: https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait

eljost commented 11 months ago

Dear xjf729,

thanks for this remark and the PR. I'll take a closer at this next week to check that it does not break anything etc.

eljost commented 11 months ago

Thanks for the PR.