search

ellatrix / wp-front-end-editor

Front-end Editor for WordPress
https://wordpress.org/plugins/wp-front-end-editor/
340 stars 87 forks source link

Embed code option on empty new line #300

Closed picajoso closed 8 years ago

picajoso commented 8 years ago

I wonder if this could be another option too for the plugin. When I want to add some embed code -for example, to insert a YouTube video- I must exit de WP Frontend Editor, go to the standard WP Editor, then enable the raw text editor and paste the text there. It would be nice to be able to add it while I'm writing.

ellatrix commented 8 years ago

Do you mean a shortcode [embed]...[/embed]? or pasting the URL? When I paste the URL of a video it creates an embed.

picajoso commented 8 years ago

Uops. Didn't know that, I see it works :) Thanks!

On Fri, Aug 19, 2016 at 12:20 PM, Ella Iseulde Van Dorpe < notifications@github.com> wrote:

Do you mean a shortcode [embed]...[/embed]? or pasting the URL? When I paste the URL of a video it creates an embed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iseulde/wp-front-end-editor/issues/300#issuecomment-240982500, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0HACUFgTnW-mxEhBD5gYxmoEdlFvCsks5qhYNUgaJpZM4JoUTf .

ellatrix commented 8 years ago

Is there a way in the admin to add embeds that is not possible with the front-end editor? You can use the media library and insert from URL, paste a URL etc. It just won't convert I think if you manually type the URL or shortcode...

Closing for now then. :)

picajoso commented 8 years ago

I really didn't know about that feature, and I guess it works for other video sites as well. However, what happens if I want to embed other things (a tweet, a Slideshare presentation maybe, a polldaddy poll)?

On Fri, Aug 19, 2016 at 12:38 PM, Ella Iseulde Van Dorpe < notifications@github.com> wrote:

Closed #300 https://github.com/iseulde/wp-front-end-editor/issues/300.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iseulde/wp-front-end-editor/issues/300#event-761100612, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0HAJoj82tuBNIXsMGXcE4jzZtOcUgLks5qhYeXgaJpZM4JoUTf .

ellatrix commented 8 years ago

Tweets should be fine too. Other embeds depend on core support, see https://github.com/WordPress/WordPress/blob/master/wp-includes/class-oembed.php. I see they are all supported, so if there are any problems pasting those URLs please reopen. If you're looking for a button or something to insert them, I'll let you add custom buttons soon, but as you can see from the list of supported services it's a bit unrealistic to add buttons for all. Not sure how else we can let the user know that they can paste URLs...

picajoso commented 8 years ago

I didn't know it was possible to add URLs and it would embed the block right away myself, so maybe this is a feature others don't know as well. Anyway, I'll keep trying this feature, you're absolutely right: adding buttons for everything is even absurd.

On Fri, Aug 19, 2016 at 2:34 PM, Ella Iseulde Van Dorpe < notifications@github.com> wrote:

Tweets should be fine too. Other embeds depend on core support, see https://github.com/WordPress/WordPress/blob/master/wp- includes/class-oembed.php. I see they are all supported, so if there are any problems pasting those URLs please reopen. If you're looking for a button or something to insert them, I'll let you add custom buttons soon, but as you can see from the list of supported services it's a bit unrealistic to add buttons for all. Not sure how else we can let the user know that they can paste URLs...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iseulde/wp-front-end-editor/issues/300#issuecomment-241006429, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0HAI0FmIiVXJ1L6pTo50iEWcnJVepMks5qhaLQgaJpZM4JoUTf .