search

elliotks / ACABM

Cookie Clicker - Auto Click and Buy Mod
GNU General Public License v3.0
2 stars 1 forks source link

Incompatible with CCSE on web version #1

Open obj-obj opened 10 months ago

obj-obj commented 10 months ago

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

elliotks commented 9 months ago

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

Hi @obj-obj would you please provide more information on your setup including so I can replicate it on my end? Does this only effect the web version? Or steam version as well.

Sorry for the late reply - for whatever reason I did not see a notification.

obj-obj commented 9 months ago

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

Hi @obj-obj would you please provide more information on your setup including so I can replicate it on my end? Does this only effect the web version? Or steam version as well.

Sorry for the late reply - for whatever reason I did not see a notification.

I don't have the game on steam, so I can't test that. You should be able to use one of the mod manager extensions (like this one) and install both mods to reproduce the issue.

elliotks commented 9 months ago

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

Hi @obj-obj would you please provide more information on your setup including so I can replicate it on my end? Does this only effect the web version? Or steam version as well. Sorry for the late reply - for whatever reason I did not see a notification.

I don't have the game on steam, so I can't test that. You should be able to use one of the mod manager extensions (like this one) and install both mods to reproduce the issue.

Thanks @obj-obj I will review this later today.

elliotks commented 9 months ago

Hi @obj-obj I installed Firefox and installed the mod manager extension https://addons.mozilla.org/en-US/firefox/addon/yaccmm/ I then added ACABM - https://cdn.jsdelivr.net/gh/elliotks/ACABM/autoclickandbuyMod/main.js Cookie Monster - https://cookiemonsterteam.github.io/CookieMonster/dist/CookieMonster.js

I did notice after adding Cookie Monster my web browser performance tanked. In the console logs many "[Violation] 'setTimeout' handler took 100+ms" type messages come up while both are enabled at the same time.

I will need more time to review this, and see if it is even possible to resolve.

Thanks,

sigboe commented 6 months ago

I can also reproduce this in Firefox, when Auto Click And Buy is loaded, either before or after CCSE is loaded, when opening the settings panel Cookie clicker hangs. In the Steam version things work.

elliotks commented 6 months ago

Hello @obj-obj and @sigboe
I have refactored the Controller and changed the way intervals and timeouts are handled - basically hooking into Cookie Clicker's logic modHook. So far it seems to resolve the issues with CookieMonster and ACABM being active together.

Please let me know how it works on the web version, I have not updated the Steam version yet since I am still testing for issues from the refactor.