search

elliotttate / beatsaver-laravel

Rewrite of beatsaver.com (https://github.com/beatsaver/beatsaver) using the laravel framework
https://discord.gg/8B44zqM
MIT License
39 stars 19 forks source link

Add genre to song #13

Open sorianog opened 6 years ago

sorianog commented 6 years ago

@Byorun This is a work in progress PR. I would like your comments on what should be added/changed. I am new to the language, so any pointers are welcome!

Attempts to partially address Issue #12

Byorun commented 6 years ago

that is a good start, but i would add the genre to the song table since it will always be the same even if the author updates the song.

sorianog commented 6 years ago

Sounds good. Made the change.

Byorun commented 6 years ago

now you need a list of genres and a way to select one in the upload/edit process

sorianog commented 6 years ago

Do we want a list of genre's or have the user fill it in themselves?

On Mon, Aug 6, 2018, 12:17 PM Byorun notifications@github.com wrote:

now you need a list of genres and a way to select one in the upload/edit process

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Byorun/beatsaver-laravel/pull/13#issuecomment-410764482, or mute the thread https://github.com/notifications/unsubscribe-auth/AMpbjxj784j-L0rdVX_51zCa1SkCmCkwks5uOGwxgaJpZM4VvKFR .

Byorun commented 6 years ago

I will be easier to search if the list is fix (maybe stored in the database)

sorianog commented 6 years ago

Trying to research the best genres to include and found this article (data from 2015): https://www.digitalmusicnews.com/2016/04/07/most-popular-music-genres-america/ Saw a 2017 report with the same genres in that article (data from the same company, Nielsen Music). That would be 11 genres to start off with.

Byorun commented 6 years ago

@sorianog Someone from Discord mention the LastFM API

razzeee commented 6 years ago

Unfortunately musicbrainz doesn't have genres yet https://wiki.musicbrainz.org/Genre But if we want to go the tag route, musicbrainz does have those

But theaudiodb does have a genre but doesn't seem to have an endpoint for that https://www.theaudiodb.com/api_guide.php

sorianog commented 6 years ago

@Razzeee Feel free to pick up this PR if you want. I can't get php to work on my Windows machine. Might have to go to a VM route...

razzeee commented 6 years ago

@sorianog sounds like https://github.com/Byorun/beatsaver-laravel/pull/19 might help you?

anyway, haven't done php/laravel for two years, not sure I want to go back

razzeee commented 6 years ago

Here's how I would do the storage. https://github.com/Razzeee/beatsaver-laravel/commit/a4a379f29b46f4350126772736389494159d7e59

It's untested so far, but should work in theory. But has no frontend and no api integration.