Bug: Song parser not checking for inconsistent filenames (json vs real filename)

elliotttate / beatsaver-laravel

Rewrite of beatsaver.com (https://github.com/beatsaver/beatsaver) using the laravel framework

https://discord.gg/8B44zqM

MIT License

39 stars 19 forks source link

Bug: Song parser not checking for inconsistent filenames (json vs real filename) #7

Closed luludotdev closed 6 years ago

luludotdev commented 6 years ago

Some songs have been uploaded with the file normal.json rather than Normal.json
This breaks part of andruzzzhka's multiplayer plugin.

Perhaps it would be a good idea to reject or normalise inconsistencies in the capitalisation of difficulty levels.

Examples: https://beatsaver.com/api/songs/detail/2376-1644
https://beatsaver.com/api/songs/detail/3301-2360

Byorun commented 6 years ago

We won't edit uploaded zips (as of now). So rejecting them would be the only way. But this should already be happening.

Byorun commented 6 years ago

After i talked to the song loader author, I decided to not restrict the upload process any further. I also forwarded the bug to "andruzzzhka's multiplayer plugin"