search

elliotttate / beatsaver-laravel

Rewrite of beatsaver.com (https://github.com/beatsaver/beatsaver) using the laravel framework
https://discord.gg/8B44zqM
MIT License
39 stars 19 forks source link

store mp3 preview files (fixes #66) #73

Open ngokevin opened 5 years ago

ngokevin commented 5 years ago

For reliable cross-browser audio previews and to support BeatSaver Viewer on platforms such as Safari/iOS. Went with MP3 over AAC due to Firefox support.

I guess optimally, these things would be done using a task queue, but I think the upload frequency is enough to do it on demand.

Using an exec / shell call-out vs php-ffmpeg because want to do it in background to not hold up the HTTP response.

ngokevin commented 5 years ago

Is anyone open to check this out? Much appreciated!

ngokevin commented 5 years ago

Done! I store it as their original filenames and handles per difficulty.

luludotdev commented 5 years ago

I'll check it out later today

ngokevin commented 5 years ago

@Assistant Also, are you handling the script for retroactive conversions?

Assistant commented 5 years ago

I can handle it, however I can't promise I'll be fast since I have a lot on my plate currently. If you want to help with it, that'd be welcome too.

ngokevin commented 5 years ago

Sure. What kind of environment is it? Do I just need to write a script that manually runs in the storage directory?

ngokevin commented 5 years ago

So good to go? I can write like a Node script that does the conversions in a queue if that sounds good.

ngokevin commented 5 years ago

Sorry to bump this (also thanks for testing the spaces in paths!). Anything else to do after the PR gets approved?

sinfuljosh commented 4 years ago

Since this is still a thing.... has anyone thought about using https://github.com/brion/ogv.js/

It’s the same setup Wikipedia uses to play ogg files one iOS