search

elm-lang / elm-platform

Bundle of all core development tools for Elm
BSD 3-Clause "New" or "Revised" License
762 stars 125 forks source link

Elm Make outputs invalid JavaScript despite valid Elm #189

Closed imdaveho closed 7 years ago

imdaveho commented 8 years ago

Smallish bug. If you try to create a union type from types declared in other modules:

type Example
    = Other.Type
    | Another.Type
    | Another.TypeTwo

This would check correctly, but would give invalid JavaScript output due to a period, ., in a variable name declared by the js output.

process-bot commented 8 years ago

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

jvoigtlaender commented 8 years ago

Please close this issue. The bug it points out is long known, and is already part of an issue reported at the compiler repository.

jvoigtlaender commented 7 years ago

@imdaveho, would you mind closing this issue, given that it is in the wrong repository and that it is a duplicate of https://github.com/elm-lang/elm-compiler/issues/1200 anyway?

jvoigtlaender commented 7 years ago

This issue should be closed! The new parser fixes it.