search

elmadev / elma-python

Elma Python Library
https://elma-python-library.readthedocs.org
MIT License
13 stars 2 forks source link

Fixed bug in error.py where only qfood was treated as objects and qex… #13

Closed sigvef closed 7 years ago

sigvef commented 7 years ago

…it and qkiller were skipped

Added is_object()

sunlelma commented 7 years ago

Looks good! Thanks for all the work you put into this :)

I noticed that in your refactoring in the lgr tests file there are a few extra lines of code that don't contribute too much now that everything is split into functions (e.g. renaming a name to "x" or changing the image when both of these things aren't necessary for the specific test anymore). Perhaps one day I'll comb through that to clean up the test lgr code.