Replay packing fix - Githubissues

elmadev / elma-python

Elma Python Library

https://elma-python-library.readthedocs.org

MIT License

13 stars 2 forks source link

Closed tiinanen closed 4 years ago

tiinanen commented 4 years ago

Hi, I noticed that I couldn't unpack some of my AI replays, which are generated using Smibu's Elma physics implementation.

While I started digging, I noticed some problems with the replay (un)packing code and some misinterpretations of the replay format and its events.

I tried to fix the biggest issues with this PR. It could be improved further for sure.

sigvef commented 4 years ago

Nice! The changes all look good. Can you bundle an example replay in the testsuite that didn't work before, but now does?

tiinanen commented 4 years ago

Ok, I added an example rec and a test for it.

jonsykkel commented 4 years ago

sigvef commented 4 years ago

Sorry for the delay. Thanks for the reminder! :)