search

elmadev / elma-python

Elma Python Library
https://elma-python-library.readthedocs.org
MIT License
13 stars 2 forks source link

Deprecate Python 2 #21

Open tiinanen opened 4 years ago

tiinanen commented 4 years ago

I haven't tried whether the code actually works on Python 2, but seems like it has been the original purpose of the library.

Since Python 2 won't be maintained starting from 1 January 2020, I think it would be best to just drop support for Python 2 since it makes it difficult to use any of the modern Python 3 features.

tiinanen commented 3 years ago

Recent PRs such as #30 #31 #32 are using features that are not supported by Python 2. Some Python 2 specific code also caused issues with type checking and has been therefore removed.

It seems to me that 3.7 is the oldest Python version that the library supports currently (e.g. from __future__ import annotations has been introduced in Python 3.7).