search

elmadev / elma-python

Elma Python Library
https://elma-python-library.readthedocs.org
MIT License
13 stars 2 forks source link

LGR support #6

Closed sunlelma closed 7 years ago

sunlelma commented 7 years ago

LGR support with image transformation, error checking, open/close, etc.

sunlelma commented 7 years ago

I feel like the .py files should be organized by level/replay/lgr as practically speaking that is how they would be used (instead of modules, packing, etc)

Anywho. Tada. LGRs.

sunlelma commented 7 years ago

Markku also points out that I mispelt transparency (as transpErAncy)

sigvef commented 7 years ago

LGR support, awesome! Do you have documentation for the LGR format somewhere? I just have a txt file with level and replay formats.

I feel like the .py files should be organized by level/replay/lgr as practically speaking that is how they would be used (instead of modules, packing, etc)

Yeah, that makes sense. I can restructure after this pull request gets merged.

sunlelma commented 7 years ago

I made this:

http://wiki.elmaonline.net/LGR/Technical

I have a few more corrections/additions to this pull request after

sunlelma commented 7 years ago

Yeah I guess I didn't test the error function as well as I should have :).

Should maybe test these errors in lgr_test py

sunlelma commented 7 years ago

Let me add some stuff to lgr_test.py

sunlelma commented 7 years ago

Done! Very comprehensive error-checking of my functions. Found a few errors thanks to that :)

Take a look again please :)

sigvef commented 7 years ago

Very nice, will review it again!

sigvef commented 7 years ago

Looks good, thank you! 🥇