search

elwayman02 / ember-data-github

Ember Data library for the GitHub API
MIT License
47 stars 38 forks source link

Upgrade to ember-cli-mirage ^1.1.0 #228

Closed code0100fun closed 4 years ago

code0100fun commented 5 years ago

Upgrade ember-cli-mirage following the suggestions in the Mirage docs.

Currently consumers of this addon can't upgrade to the Mirage >= 1.0 due to the mirage-support/factories using import { faker } from 'ember-cli-mirage';.

This PR adds ember-auto-import to pull in faker straight from node_modules/. Users who are already upgrading to Mirage 1.0 will likely already have this dependency since it is the recommended fix in the docs.

Users who are on older versions of Mirage will probably not have any issues since the import of faker with ember-auto-import should be transparent to them.

Before Merging:

elwayman02 commented 5 years ago

It appears that mirage >1.0 may require Node 8. We will need to upgrade the rest of this project before landing this change. Unfortunately, I am traveling for a family death at the moment, so I'm unable to look at this for at least a week or more. @Dhaulagiri can you coordinate with @code0100fun on landing this change along with the other upgrades?