Closed ptitzler closed 1 year ago
Linting errors and subsequent test failures are unrelated to the changes introduced by this PR. A new major version of black
was published yesterday. We currently have no upper version cap in place. https://github.com/elyra-ai/elyra/issues/3096
Code generation produces incorrect results (and in some scenarios fails) for some pipeline parameter scenarios. Examples below, as observed in the generated Python DSL:
"
character (YAML parser chokes)"
character for parameter typeString
False
forBool
-typed parameters is missing , e.g.Some of the problems were caused by the fact that
0
and<empty-string>
were considered to be equivalent (or not equivalent) toNone
. To avoid these issues thePipelineParameter
class now explicitly assignsNone
to parameter values and default values that are set to the empty string by the UI.Signed-off-by: Patrick Titzler ptitzler@us.ibm.com
What changes were proposed in this pull request?
How was this pull request tested?
To test create and export a KFP pipeline that utilizes pipeline parameters, covering the scenarios listed in the problem description. The generated Python DSL code should properly reflect the pipeline parameters, their values, and types.
Developer's Certificate of Origin 1.1