emacs-eaf / eaf-browser

A modern, customizable and extensible browser in Emacs
GNU General Public License v3.0
129 stars 26 forks source link

let eaf browser can remember local file history #30

Closed ctrl2wei closed 2 years ago

ctrl2wei commented 2 years ago

eaf-browser-ignore-history-list is enough to control remember local file history or not.

manateelazycat commented 2 years ago

@MatthewZMD I remeber file:// rule is add by you, maybe we should add some customize option to control whether remeber local file url?

ctrl2wei commented 2 years ago

eaf-browser-ignore-history-list 已经包含了 "file://" https://github.com/emacs-eaf/eaf-browser/blob/de4888325aa73966e7a4867edd545085a18e545c/eaf-browser.el#L151-L154

AppBuffer._record_history 已经根据 eaf-browser-ignore-history-list 对历史记录进行了过滤 https://github.com/emacs-eaf/eaf-browser/blob/de4888325aa73966e7a4867edd545085a18e545c/buffer.py#L387 https://github.com/emacs-eaf/eaf-browser/blob/de4888325aa73966e7a4867edd545085a18e545c/buffer.py#L417

我觉得就不需要在 AppBuffer.record_history 写死不记录本地文件了(第430行) https://github.com/emacs-eaf/eaf-browser/blob/de4888325aa73966e7a4867edd545085a18e545c/buffer.py#L425-L431

MatthewZMD commented 2 years ago

可以的