emacs-eaf / eaf-browser

A modern, customizable and extensible browser in Emacs
GNU General Public License v3.0
129 stars 26 forks source link

Eaf browser open in new frame instead of inside buffer on emacs 29 #37

Closed Ghibranalj closed 2 years ago

Ghibranalj commented 2 years ago

To Reproduce Open eaf-browser using (eaf-open-browser)

Expected behavior it should be rendered inside the buffer

Versions (please complete the following info):

Screenshots Screenshot from 2022-07-19 22-43-17 Additional context I just upgraded from emacs 28 to 29.

manateelazycat commented 2 years ago

wayland still not support

Ghibranalj commented 2 years ago

I am on X11. It works before i updated to emacs 29

MatthewZMD commented 2 years ago

Can you try to downgrade to emacs28 and see if it is working again? Just to verify that it is emacs 29 messing up things.

If so, we might not do anything at the moment, emacs 29 is at its very early stage and there are changes every single day, it is unrealistic for us third-party libraries to support the master branch atm.

manateelazycat commented 2 years ago

Because wayland not allow EAF reparent on Emacs, we can't use xreparent technology.

Because wayland not allow get active application window, we can use toplevel Qt window technology like macOS.

Sorry, we nothing can do for Wayland.

You upgrade to Emacs 29 that Emacs developer enable pgtk default, please re-compile Emacs without pgtk option if you want use Emacs 29.