search

emacs-eaf / eaf-browser

A modern, customizable and extensible browser in Emacs
GNU General Public License v3.0
129 stars 26 forks source link

'eaf-import-chrome-bookmarks' triggers 'wrong-number-of-arguments' error #38

Closed benthamite closed 2 years ago

benthamite commented 2 years ago

Describe the bug Invoking eaf-import-chrome-bookmarks results in a wrong-number-of-arguments error.

Expected behavior Bookmarks are imported

Inspecting the Emacs Lisp command, it looks like this is simply because eaf-read-input takes four arguments, but only three are passed to it. Replacing (when (eaf-read-input "Are you sure to import chrome bookmarks to EAF" "yes-or-no" "") with (when (eaf-read-input "Are you sure to import chrome bookmarks to EAF" "yes-or-no" "" "") solves the issue. (The same fix should be applied to the Firefox command.)

manateelazycat commented 2 years ago

Can you help send PR to fixed this?

Thanks. ;)

benthamite commented 2 years ago

Hi, I just submitted a pull request. This is the first pull request I submit (I'm not a programmer), so please let me know if there's anything wrong with the process I followed.