Closed taquangtrung closed 1 year ago
Yes, it still works. I just added the option for a light theme inside dark mode.
For the current dark theme, some black texts are invisible, like the text WIKIPEDIA below
In the light theme of the dark mode, the text is visible, and theme is eye-comfortable
Hi,
In this PR, I implement a feature to allow eaf-browser to display in either a light theme or a dark theme in the dark mode. This option is controlled by the new variable
eaf-browser-dark-mode-theme
, when it is set tolight
ordark
.It is accompanied by https://github.com/emacs-eaf/emacs-application-framework/pull/1018
Here is an example of the light theme (when dark-mode is enabled):
And her is the original dark theme:
Can you review and consider merging it?
Thanks!