search

emacs-eaf / eaf-browser

A modern, customizable and extensible browser in Emacs
GNU General Public License v3.0
129 stars 26 forks source link

support both dark and light theme in dark mode #43

Closed taquangtrung closed 1 year ago

taquangtrung commented 1 year ago

Hi,

In this PR, I implement a feature to allow eaf-browser to display in either a light theme or a dark theme in the dark mode. This option is controlled by the new variable eaf-browser-dark-mode-theme, when it is set to light or dark.

It is accompanied by https://github.com/emacs-eaf/emacs-application-framework/pull/1018

Here is an example of the light theme (when dark-mode is enabled):

emacs-light

And her is the original dark theme:

emacs-dark

Can you review and consider merging it?

Thanks!

manateelazycat commented 1 year ago

https://github.com/emacs-eaf/eaf-browser/blob/2dd03428376ece4028e3c028763a0b436f15fbc8/eaf-browser.el#L175 can't work?

taquangtrung commented 1 year ago

Yes, it still works. I just added the option for a light theme inside dark mode.

taquangtrung commented 1 year ago

For the current dark theme, some black texts are invisible, like the text WIKIPEDIA below

emacs-dark

In the light theme of the dark mode, the text is visible, and theme is eye-comfortable