search

emacs-eaf / eaf-browser

A modern, customizable and extensible browser in Emacs
GNU General Public License v3.0
129 stars 26 forks source link

support toggle dark mode between light theme or dark theme #57

Closed taquangtrung closed 1 year ago

taquangtrung commented 1 year ago

Hi,

I implemented a small PR to allow users quickly switch between the light theme and dark theme of dark mode.

This is relevant to this PR: https://github.com/emacs-eaf/eaf-browser/pull/43

Can you consider merging it?

Thanks!

manateelazycat commented 1 year ago

why remove code of update_theme？

it use change color of browser when emacs change theme automatically

taquangtrung commented 1 year ago

Oh, I didn't see the function update_theme is called else where, so I removed that code.

I just reverted it back, but add a condition to control when to reload the configuration from Emacs.

manateelazycat commented 1 year ago

looks good，thanks