emacs-exwm / exwm

Emacs X Window Manager
https://elpa.gnu.org/packages/exwm.html
GNU General Public License v3.0
278 stars 14 forks source link

Adrián is breaking `describe-package-1` #78

Closed port19x closed 2 months ago

port19x commented 2 months ago

When trying to click on exwm or xelb in the package list (after running package-list-packages) I get the following error:

describe-package-1: Wrong type argument: char-or-string-p, ("Adrián Medraño Calvo" . "adrian@medranocalvo.com")

That's pretty funny. Not sure what you can do about it

medranocalvo commented 2 months ago

This is getting personal ;-).

Seems to have been fixed some months ago: https://github.com/emacs-mirror/emacs/commit/73cb931e5bab1b956f0569cd542468cfa7f4c9a7

A simple solution would be listing a single maintainer (one of @Stebalien or @minad) and keeping the others in the Author: or a different field (Also-Maintainers:).

port19x commented 2 months ago

Are you sure this is the multiple maintainers issue and not perhaps caused by emacs struggling with unicode? For clarification, I'm using emacs 29.4 with the latest exwm and xelb from elpa-devel.

I'll check with emacs master just to be sure

port19x commented 2 months ago

Yep, you're right. It works with emacs 31, and probably emacs 30 as well

medranocalvo commented 2 months ago

Reopening, we should fix this: users should be able to see the description of the package.

@port19x: thank you for reporting and checking Emacs 29 vs Emacs 31.

minad commented 2 months ago

This issue is also present in many other (also more popular) packages with multiple maintainers. I consider the issue wontfix from our side. The impact of this package.el bug is rather small, it only presents itself when showing the package information and nowhere else, only on Emacs 29 and older. Reducing the maintainer header to a single maintainer has downsides, e.g., the other maintainers won't get release notification mails from ELPA builder anymore.

medranocalvo commented 2 months ago

@minad, I defer to your judgement here. Thank you.