search

emacs-lsp / lsp-haskell

lsp-mode :heart: haskell
https://emacs-lsp.github.io/lsp-haskell
GNU General Public License v3.0
233 stars 63 forks source link

Add custom `lsp-clients-extract-signature-on-hover` #187

Open slotThe opened 3 months ago

slotThe commented 3 months ago

It seems like https://github.com/emacs-lsp/lsp-mode/issues/4362 didn't get any traction, so I'm following what was discussed in https://github.com/emacs-lsp/lsp-haskell/issues/151 and am creating an individual PR here instead.

Before: 2024-08-17-144642_1108x206_scrot

After: 2024-08-17-144117_903x177_scrot

Commit Summary

Add custom lsp-clients-extract-signature-on-hover

This fixes a case where a type signature would be broken up over multiple lines, and we only display the first of these.

Fixes: https://github.com/emacs-lsp/lsp-haskell/issues/151 Related: https://github.com/emacs-lsp/lsp-mode/issues/4362 Related: https://github.com/emacs-lsp/lsp-mode/pull/1740

michaelpj commented 2 months ago

I wonder if a PR to upstream might get more traction?

slotThe commented 2 months ago

This is essentially what https://github.com/emacs-lsp/lsp-mode/pull/1740 was, but that sadly also went nowhere :/