Incomplete Installation Instructions/README

emacs-lsp / lsp-sonarlint

lsp-mode :heart: sonarlint

GNU General Public License v3.0

82 stars 13 forks source link

Incomplete Installation Instructions/README #10

Open liar666 opened 3 years ago

liar666 commented 3 years ago

Hi,

I've tried to install lsp-sonarlint. I'm particularly interested in its Java & JavaScript components.

Following the README in this repo, I did:

Install lsp-sonarlint in Emacs packages from MELPA

Complete my Emacs config file with

(require 'lsp-sonarlint)
(require 'lsp-sonarlint-javascript)
(setq lsp-sonarlint-javascript-enabled t)
(require 'lsp-sonarlint-java)
(setq lsp-sonarlint-java-enabled t)

But I get an error when starting Emacs: File is missing: Cannot open load file, No such file or directory, lsp-sonarlint-javascript

You might have forgotten to give some steps in the install procedure in the README...

Could you please complete the README/docs so that a newbie like me can install a fully working Emacs + sonarlint setup?

Thanks

Sasanidas commented 2 years ago

Sorry about the response delay.

I reinstall the extension with the default settings, and seems like it work as intended, maybe you decline when lsp-sonarlint ask to download the extension? The behaviour is that if it doesn't found the extension, it will download it for you.

MarcoHassan commented 2 years ago

Hi all,

I also have troubles to keep up and running with this cool lsp integration.

I downloaded all the relevant package and set the relevant variables after requiring the module

   (use-package lsp-sonarlint
     :ensure t)

   (require 'lsp-sonarlint-java)
   (setq lsp-sonarlint-java-enabled t)

The sonarlint server seems to work and I do not get any errors. I can see a server at localhost:64474. I checked at the variables defined in the lsp-sonarlint-java module and they are correctly set.

Still when I try on purpose to introduce some non-compliant code as per here I do not get any sonarlint warnings.

Any suggestions? I suggest to write a 101 with a tutorial with example as per lsp-java or similar.

Best, Marco

ppena-LiveData commented 1 year ago

Same for me. When I ran M-x lsp, I saw messages like the below that showed no errors or warnings, so I assume lsp-sonarlint installed what it needed, but I'm not seeing any SonarLint warnings from known problem code:

Contacting host: binaries.sonarsource.com:443
Wrote c:/Users/ppena/AppData/Roaming/.emacs.d/elpa/lsp-sonarlint-20220510.1802/languages/sonar-python.jar
LSP :: Connected to [pylsp:51512 c:/git/my-test-proj].

Is there some way to check if lsp-sonarlint is properly configured? I see *lsp-mode* and *pylsp* buffers in Emacs; should there also be a messages buffer for lsp-sonarlint?

Sasanidas commented 1 year ago

Thanks for the feedback, It's true that the server seems lo work as intended but for some reason is not triggering any code-action or warning.

This maybe because of the new version of the lsp server of sonarlint that may require some adjustment or this repository integration with lsp-mode that need to be fixed/updated.

In any case, I'm kind of lost, so ping @yyoncho , maybe he can give you more details.

necto commented 1 year ago

I have upgraded SonarLint and its plugins to the latest versions used in the VSCode plugin in this PR. The CI tests suggest that it works pretty reliably. Please give it a go.

necto commented 4 months ago

https://github.com/emacs-lsp/lsp-sonarlint/pull/22 has improved the on-boarding experience. Is this issue still relevant?