Treemacs will not expand

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs

GNU General Public License v3.0

403 stars 48 forks source link

Treemacs will not expand #137

Closed invisiblegaudi closed 2 years ago

invisiblegaudi commented 2 years ago

When I use the lsp-treemacs-references, the tab in the buffer below appears, with the count but it won't expand - when I tab over it, it just replicates across the minibuffer. Experiencing this on both OSX and Ubuntu. Using spacemacs flavour. Previous to this after an update, I noticed the tab/results design changed and it would replicate once only and then expand. This is an essential tool for refactoring, I am reduced to helm-projectile-rg-ing everything now to find the references :sob:

RidaAyed commented 2 years ago

Same here after updating spacemacs packages. Rolling back the package updates fixes the problem.

No issues with state before update:

System Info before update :computer:

LSP :: lsp-mode 20220815.958, Emacs 28.2, gnu/linux [Treemacs] v2.10 (installed 2022.08.15) @ Emacs 28.1

OS: gnu/linux
Emacs: 28.2
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. e37e8e227)
Graphic display: t
Running in daemon: nil
Distribution: spacemacs
Editing style: vim
Completion: ivy

Layers:

((treemacs :variables treemacs-use-follow-mode t treemacs-use-filewatch-mode t treemacs-use-git-mode 'simple treemacs-use-all-the-icons-theme t)
)

yyoncho commented 2 years ago

Can you try using treemacs from melpa stable? There is a breaking change in treemacs itself. (before that you may also need to wipe lsp-treemacs)

timfel commented 2 years ago

Throwing out my .emacs.d and starting fresh, but this time installing treemacs from melpa-stable didn't help. Afaics, they updated the version in melpa stable again just after the breaking change

yyoncho commented 2 years ago

Yep, you have to pit to the 2.11 commit.

I am working on a fix, it will be available soon(I hope tomorrow)

yyoncho commented 2 years ago

It should be good now. The only thing that is broken is automatic expansion, I will fix it once we have the corresponding piece on treemacs side

timcharper commented 1 year ago

For packages which still refer to lsp-treemacs-initialize, what should they call now?

https://github.com/emacs-lsp/lsp-mssql/blob/88319a61a06e27fc1d3ea2e7b853ec1692b4c166/lsp-mssql.el#L607

https://github.com/emacs-lsp/lsp-mssql/issues/17

yyoncho commented 1 year ago

@timcharper they should be rewritten to use lsp-treemacs-render