search

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
403 stars 48 forks source link

No thread selected when debugging #144

Closed st1971 closed 1 year ago

st1971 commented 1 year ago

when debugging (java / c / rust) getting invalid-function lsp-treemacs-wcb-unless-killed message, if starting via lsp-start-plain no thread is select when debugging and breakpoint is hit (process does stop at a break point but it is not highlighted until the thread is selected manually) the thread has to be re-selected after each step over / into.

the invalid-function lsp-treemacs-wcb-unless-killed message seems to be related to the setting of with-expanded-depth on treemacs-initialize.

running emacs 28.1 with spacemacs

st1971 commented 1 year ago

new version/build of treemacs (20221010.1959) landed on MELPA last night, this seems to resolve the invalid-function lsp-treemacs-wcb-unless-killed error. the problem with thread selection on breakpoint is still there though

hersheleh commented 1 year ago

I am having the same issue when using dap-lldb. Do you know what lisp command corresponds to selecting the thread manually?

yyoncho commented 1 year ago

@hersheleh atm the thread can be selected from dap-ui-sessions. I will take a look what is causing this problem.

yyoncho commented 1 year ago

@kiennq is adding when here https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-mode.el#L1923 was really needed? Seems like it might cause more regressions like that. Can we revert that change if it wasn't needed?

kiennq commented 1 year ago

@yyoncho Fix here https://github.com/emacs-lsp/lsp-mode/pull/3763

st1971 commented 1 year ago

@yyoncho Many thanks for this all working for me now