feat(api): add string ids option to contact get data endpoint

emartech / suite-js-sdk

Simple Javascript wrapper for the Emarsys API

MIT License

9 stars 35 forks source link

Closed gabor-balla-emarsys closed 8 years ago

bankyadam commented 8 years ago

I think that these are not stringIds, even if the Suite API calls them that way. I'd call this option nameAsKey or something like it.

gabor-balla-emarsys commented 8 years ago

I'm not sure about the right wording, but I would stay consistent with the naming convention used by the API / API documentation.

bankyadam commented 8 years ago

LGTM

gabor-balla-emarsys commented 8 years ago

Thank you!