search

embassy-rs / embassy

Modern embedded framework, using Rust and async.
https://embassy.dev
Apache License 2.0
5.61k stars 777 forks source link

nrf: Add NFCT driver. #3552

Closed Dirbaio closed 2 days ago

Dirbaio commented 2 days ago

Based on original work in #2113 by @i404788 and @turbocool3r . Duly credited in Co-Authored-By.

turbocool3r commented 1 day ago

Thanks! Been waiting for this to happen for a while 😄

turbocool3r commented 1 day ago

I can probably test this thing at some point in the feature (December-January). So far the only problem I've observed is sending an empty frame leads to a hang. Also there is some workaround in nrfx for an issue when no response is sent to an RX'ed frame, likely needs testing as well.

Dirbaio commented 1 day ago

is sending an empty frame even allowed? are there any card protocols out there that need it?

turbocool3r commented 15 hours ago

is sending an empty frame even allowed? are there any card protocols out there that need it?

I don't think so, but I think this needs to be handled with an error or an early exit to prevent the hang.