embassy-rs / nrf-softdevice

Apache License 2.0
256 stars 76 forks source link

Fix GATT derive visibility #182

Closed vE5li closed 1 year ago

vE5li commented 1 year ago

I noticed that when deriving gatt_client, the methods would always be private. I implemented the same logic as for gatt_server, meaning the methods will be public if the field itself is public.

Edit: forgot to mention that I also noticed a single method on gatt_service not having the expected visibility, so I changed that as well.

Dirbaio commented 1 year ago

Makes sense, thank you! :)