search

ember-animation / ember-animated

Core animation primitives for Ember.
https://ember-animation.github.io/ember-animated/
MIT License
245 stars 90 forks source link

Support strict embroider builds #647

Closed mike-engel closed 11 months ago

mike-engel commented 1 year ago

Potential solution for #594, alternative for #633.

Should also fix #642.

This uses the macroDependencySatisfies helper and brings back ensure-safe-component

villander commented 1 year ago

@SergeAstapov is there anything I can help to get it merged and released?

SergeAstapov commented 1 year ago

@villander this fix is not working, hence it's not ready to be merged

mike-engel commented 1 year ago

@villander @SergeAstapov I've decided that macros are too buggy right now, and opened #657 to drop support for the old version of ember-element-helper instead.

mike-engel commented 11 months ago

Closing in favor of #657

mansona commented 11 months ago

@mike-engel just to let you know we released your PR to embroider in https://github.com/embroider-build/embroider/releases/tag/v4.1.3-%40embroider%2Faddon-dev in case you want to try this approach again?

mike-engel commented 11 months ago

@mansona I think since https://github.com/ember-animation/ember-animated/pull/657 has been accepted, that would trump this PR anyway. If this PR is still desired I can try again, but I don't think it's worth it