search

ember-fastboot / ember-cli-head

Ember Cli Addon for Adding Content to HTML Head
MIT License
98 stars 34 forks source link

Engines support #23

Open amk221 opened 7 years ago

amk221 commented 7 years ago

Curious what the thinking is on this? thanks for any info

edit: currently I don't think it works

knownasilya commented 6 years ago

Would love this too, currently, I get the following error:

Assertion failed: Error: Could not find module `dashboard/templates/head` imported from `dashboard/components/head-content`

I'm using this module indirectly via ember-page-title. This happens probably because all of the content is defined in the app folder, where engines use addon. Creating an app/templates/head.hbs in the engine doesn't help.

robclancy commented 6 years ago

To get this working with ember-page-title I had to share 'headData' service with the engine. Also I have ember-page-title as a dependency in the engines package.json. Without using ember-page-title I believe you will need to add ember-cli-head as a dependency in there.

This might just all work on latest simply with the package as a dependency. I haven't tested as I only need this for ember-page-title at this stage.

Similar requirements to https://github.com/tim-evans/ember-page-title/issues/112#issuecomment-349747991