ember-learn / deprecation-app

Deprecation guides for ember.js, ember-data, and ember-cli
https://deprecations.emberjs.com/
22 stars 69 forks source link

Add parent relationship to deprecations to allow grouping in the UI, especially in the index #1383

Open kategengler opened 1 month ago

kategengler commented 1 month ago

No deprecations currently use this, though I did certainly test it out. I am aiming to use this for #1381 so we do not lose the usefulness of the index. Due to the way the Deprecateimport Ember from 'ember'`` deprecation is done, we need a URL for every single API even if they weren't ones that were at all used by the public. I don't want the index to scare people off of upgrading to 6.0, but there should still be a way to see all the related deprecations.

cc @NullVoxPopuli

netlify[bot] commented 1 month ago

Deploy Preview for ember-deprecations ready!

Name Link
Latest commit 35847f911c0ae50499eb24e839f507392980bc7a
Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/665f7367f4770500083a6c30
Deploy Preview https://deploy-preview-1383--ember-deprecations.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MinThaMie commented 1 month ago

We discussed this during our learning meeting on 17th of June, and while we understand that it's a ton of deprecations we believe introducing this new data pattern/structure is not necessary and makes it more complicated to maintain.

We have plans to structurally address the issue you ran into. I hope you understand :) Thanks for the PoC!

kategengler commented 1 month ago

Do you have a timeline for addressing the issue? We're attempting to land the deprecation of import Ember from 'ember' which is the one that introduces 150 deprecations, most of which will not be relevant for most users.

MinThaMie commented 1 month ago

We're happy to land that deprecation as is :) it does not seem to effect the usability of the page, so you could merge import Ember from ember right now if you want to.

kategengler commented 1 month ago

To me it greatly affects the usability of that page. I find users often browse deprecations by version to get an idea of what is required for a particular upgrade. Adding 150 deprecations, most of which are for things that are somewhat esoteric, is very discouraging for someone looking at that list -- it isn't easy to tell at a glance that they are grouped under this deprecation of the import of Ember. It also drowns out the other deprecations with that version.