search

ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
86 stars 185 forks source link

Update browser-support.hbs to include v5 #1059

Closed SergeAstapov closed 10 months ago

SergeAstapov commented 1 year ago

https://emberjs.com/browser-support/ states v3 in present tense and talks about v4 in future tense, which is outdated.

Also v5 has been released some time ago but page does not mention it.

netlify[bot] commented 1 year ago

Deploy Preview for ember-website ready!

Name Link
Latest commit f10fb4e86ef815fd09c77b3510e23751a22107d3
Latest deploy log https://app.netlify.com/sites/ember-website/deploys/655b8fd8730ce00008d2b453
Deploy Preview https://deploy-preview-1059--ember-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kategengler commented 10 months ago

This seems fine to me but might miss some of the nuance of the browser support policy that started with v4. I am surprised to find #884 never landed.

SergeAstapov commented 10 months ago

@kategengler totally agree! I was pretty sure I would miss some details, but seems like page in current state makes bad impression of being neglected and having some details missed is better than not having totally outdated content.

My assumption would be: if there is no wrong content in here and structure looks good, land it and iterate to clarify and refine the details.

kategengler commented 10 months ago

I think that's fine but do still wonder why #884 was never landed.

For future reference, browser support is a rolling window for the evergreen browsers that can be updated in each minor. Current support can be seen here https://github.com/emberjs/ember.js/blob/main/lib/browsers.js and this is also exported on Ember's index, so in node require('ember').supportedBrowsers gets the list.

This is the relevant RFC https://rfcs.emberjs.com/id/0685-new-browser-support-policy/