ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 21 forks source link

Add a percy snapshot for the expanded mobile menu #139

Open mansona opened 1 year ago

mansona commented 1 year ago

We curren't don't have any percy snapshots for the expanded percy menu. I'm not entirely sure if we can have a percy snapshot for just one particular size 🤔 but it would be nice if it were possible.

jenweber commented 1 year ago

Yes, you can do size changes for individual snapshots!

https://docs.percy.io/docs/cli-configuration#per-snapshot-configuration

https://docs.percy.io/docs/ember

DeRaowl commented 1 year ago

Hey Manson, Would love to work on this issue?

MinThaMie commented 2 months ago

This is more complicated than it looks, because we need to also press the button to see what is in the menu and not only resize the Percy screenshots. I've not yet figured out how to resize the window, press the button and then take the screenshot