search

ember-polyfills / ember-destroyable-polyfill

Polyfill for RFC 580: Destroyables
MIT License
4 stars 3 forks source link

Storybook build fails with ember-destroyable-polyfill #96

Open gossi opened 4 years ago

gossi commented 4 years ago

I've upgrade hokulea to latest dependencies PR: hokulea/hokulea#13

With that I've upgrade to @glimmer/component and @glimmer/tracking to v1.0.1 and ember to v3.20 and not sure which one of those upgrades brings in ember-destroyable-polyfill. However, they break my storybook build on netlify. Here is the log: https://app.netlify.com/sites/hokulea/deploys/5f42add1bae43a0008544de5 (@hokulea/explorer is the addon which runs the storybook). The build runs locally for me, which keeps me wondering.

There is more to it, that might all depend together. Also the tests work for me locally but fail on github actions. Here is the latest run: https://github.com/hokulea/hokulea/pull/13/checks?check_run_id=1018844223

Which brings me to that fact, that I reported a similar problem to storybook: storybookjs/storybook#11853 I thought this issue is because storybook runs its own webpack bundling and as part of that fails to parse the template in there. Now I think, this is even more connected to ember itself.

I'm kind stuck with this but happy to provide help or am up for pairing

rwjblue commented 4 years ago

Hmm, neither @glimmer/component nor @glimmer/tracking use this polyfill themselves. My guess would be something like ember-modifier@2 (which does use this polyfill).

rwjblue commented 4 years ago

The failure in that PR's tests that I see:

Build Error (broccoli-persistent-filter:Babel > [Babel: @hokulea/buttons]) in @hokulea/buttons/components/accent-button/stories.ts
@hokulea/buttons: /home/runner/work/hokulea/hokulea/packages/buttons/@hokulea/buttons/components/accent-button/stories.ts: Can't reference '{"id":"f8hLISdf","block":"{\"symbols\":[],\"statements\":[[2,\"\\n      \"],[8,\"accent-button\",[[24,\"aria-label\",\"Go Tomster!\"]],[[],[]],[[\"default\"],[{\"statements\":[[2,\"\\n        \"],[10,\"span\"],[14,\"aria-hidden\",\"true\"],[12],[2,\"🐹\"],[13],[2,\"\\n      \"]],\"parameters\":[]}]]],[2,\"\\n    \"]],\"hasEval\":false,\"upvars\":[]}","meta":{}}' as a bare identifier (This is an error on an internal node. Probably an internal error.)

Is also seems unrelated to this polyfill 🤔