search

emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 119 forks source link

remove proposal plugins and replace with their corresponding transform #489

Open mansona opened 1 year ago

mansona commented 1 year ago

plugin-proposal-class-properties, plugin-proposal-decorators, plugin-proposal-private-methods, and plugin-proposal-private-property-in-object are all now renamed to transform since they are out of proposal stage so this PR updates the dependencies 👍

mansona commented 1 year ago

So I noticed when the tests were failing that actually I missed some code that was trying to do smart stuff with ordering the plugins. I have pushed a really naive way to update that code but I have a seeking suspicion that we need to check for both the cases of "proposal" plugins and "transform" plugins, favouring the transform ones but catering for the case that people still use proposal ones 🤔

Can someone with more context in this area let me know if they thing that is required?

Windvis commented 12 months ago

I think we can simply remove these plugins as they are part of preset-env v7.14+ (and we list 7.20 as a dependency): #501