search

emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 119 forks source link

Ensure that plugin-transform-class-static-block is provided #502

Closed NullVoxPopuli closed 11 months ago

NullVoxPopuli commented 11 months ago

Found this issue while working on: https://github.com/ember-template-imports/ember-template-imports/pull/187

I tested over on that branch locally by editing the node_modules directly.

The test suite here in ember-cli-babel can't be trusted because @babel/plugin-transform/class-static-block was picked up automatically due to how bad yarn@v1's hoisting is -- the static-block plugin was resolved via @babel/preset-env -- preset-env does not inherently provide static-blocks -- it must be configured when we compile away class properties.

If this repo were to switch to using a real package manager, the the static test would fail without the corresponding change in lib/ember-plugins.js

NullVoxPopuli commented 11 months ago

failures look to be due to network issues