NOTE: the main branch will not be releasable during this time, because we need to complete the plan, so that there is minimal/zero disruption to folks' test suites.
[x] release another v3 version, since the types fix is still unreleased.
we should keep changes on this branch to the bare minimum, as we don't want to need to sync back to main unless we really have to.
NOTE that the v3 branch is a snapshot of what this repo looked like before everything is this quest issues started happening
[x] separate test-app for ember-concurrency@v2 (it requires ember-concurrency-ts, which uses a version of ComputedProperty which is different from the built-in types)
https://github.com/emberjs/ember-test-waiters/pull/464
[ ] update README so that folks can discover how to best ensure only one copy of @ember/test-waiters is present across all their dependencies (which won't be required for the waiter system to work, but will be required to get improvements across the whole dep graph)
[ ] add notes for addon authors to utilize peerDependencies with @ember/test-waiters (with permissive range, which would be allowed post-globalThis usage) with state held on globalThis, we don't need peerDependencies, we can allow duplicates of test-waiters. Using dependencies instead of peerDependencies can help make installation experience smoother for folks, however everyone should end up having @ember/test-waiters declared in their apps anyway.
[ ] note that peers however help with install time and debugging but won't be necessary for things to work.
[ ] release new version of ember-test-waiters that re-exports everything from @ember/test-waiters
this is needed because some super old projects import from ember-test-waiters, and if someone is using v4 of test waiters, yet part of their dep graph uses the super old ember-test-waiters, we may want to do this to allow users control over which @ember/test-waiters their deep dep of ember-test-waiters is using.
We may also want to "wait and see" if this problem even exists.
NOTE: the
mainbranch will not be releasable during this time, because we need to complete the plan, so that there is minimal/zero disruption to folks' test suites.Here is a preview of what's in the next major:
In order of blockers:
mainunless we really have to. NOTE that the v3 branch is a snapshot of what this repo looked like before everything is this quest issues started happeningCan happen in any order
ComputedPropertywhich is different from the built-in types) https://github.com/emberjs/ember-test-waiters/pull/464ember-fetch@v8mainbranch -- already implemented a long time ago viagetGlobaland storing theWAITERSonglobalThis.@ember/test-waitersto a native packageWAITERS' keys. (allows deleting code)@ts-ignorefrom the test-appsfetch-- coordinate with https://github.com/ember-cli/ember-fetch/issues/738@ember/test-waitersis present across all their dependencies (which won't be required for the waiter system to work, but will be required to get improvements across the whole dep graph)add notes for addon authors to utilizewith state held onpeerDependencieswith@ember/test-waiters(with permissive range, which would be allowed post-globalThisusage)globalThis, we don't needpeerDependencies, we can allow duplicates of test-waiters. Usingdependenciesinstead ofpeerDependenciescan help make installation experience smoother for folks, however everyone should end up having@ember/test-waitersdeclared in their apps anyway.ember-test-waitersthat re-exports everything from@ember/test-waitersthis is needed because some super old projects import from ember-test-waiters, and if someone is using v4 of test waiters, yet part of their dep graph uses the super old ember-test-waiters, we may want to do this to allow users control over which@ember/test-waiterstheir deep dep ofember-test-waitersis using. We may also want to "wait and see" if this problem even exists.ember-test-waitersas deprecated https://www.npmjs.com/package/ember-test-waiters