emberjs / list-view

An incremental rendering list view for Ember.js
MIT License
465 stars 116 forks source link

Fix README Documentation #240

Closed jmurphyau closed 9 years ago

jmurphyau commented 9 years ago

It appears the main example in the README is incorrect.

See stackoverflow question/answer http://stackoverflow.com/questions/29921395/how-do-you-use-ember-js-addons/29927126

jmurphyau commented 9 years ago

Issue #227 and pull request #230 both relate to this problem. There is discussion around the collection helper and additional changes in #230 - I was going to close this PR but I'll leave it open for someone with access to close if they see fit..

This PR solves the main issue on README and doesn't really cover anything else like #230 does. Merging this PR might solve the larger problem quicker leaving #230 open for all the other things? Or get rid of this and leave it all as #230..